Opentelemetry metrics backend #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 1, 2022 19:21
adamw
reviewed
May 4, 2022
adamw
reviewed
May 4, 2022
Pask423
changed the title
adamw
reviewed
May 6, 2022
| openTelemetry: OpenTelemetry, | ||
| meterConfig: Option[MeterConfig] = None, | ||
| requestToInProgressCounterNameMapper: Request[_, _] => Option[CollectorConfig] = (_: Request[_, _]) => | ||
| Some(CollectorConfig(DefaultRequestsInProgressCounterName)), |
There was a problem hiding this comment.
shouldn't we provide some units as default?
There was a problem hiding this comment.
In fact unit itself is optional and we are using it in many contexts so I am not sure what exactly should be used as default unit
adamw
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.