Don't explicitly set Content-Type on multipart/form-data requests #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Nov 23, 2020
| request.headers.foreach { case header @ Header(name, value) => | ||
| // for multipart/form-data requests dom.FormData is responsible for setting the Content-Type header | ||
| // as it will also compute and set the boundary for the different parts, so we have to leave it out here | ||
| if (header != Header.contentType(MediaType.MultipartFormData)) rheaders.set(name, value) |
There was a problem hiding this comment.
- There's a
Headers.is(String)method for a case-insensitive check of the header's name - we probably should use it here - I was wondering why no tests failed before :) And looking closer, there's a
send a multipart message with custom content typetest which is disabled for Scala.JS (seeFetchHttpTest). Maybe we should add another test, which explicitly sets the content-type header toMultipartFormData(+ a multipart body)? - Shouldn't we ignore all multipart content-type headers for scala.js? That is, just looking at the value's prefix, if it's not
multipart/Or maybe if the content-type is set to something different thanmultipart/form-data(which we are able to support), we should throw an exception - as we can't send a request which has e.g.multipart/mixedset. An exception is not nice, but maybe better than silently filtering things out.
There was a problem hiding this comment.
I've just pushed an update that should address your remarks. I went with your suggestion of throwing an exception for multipart types other than multipart/form-data This is also consistent with the behaviour in case of unsupported streaming bodies.
sbrunk
force-pushed
the
dont-set-content-type-for-form-data
branch
from
7c8a82e to
a2238e3
Compare
|
Thanks! Released in v3.0.0-RC10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in softwaremill/tapir#860
Before submitting pull request:
sbt compilesbt compileDocssbt testsbt scalafmt