Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new validators #1567

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Add new validators #1567

merged 1 commit into from
Nov 1, 2021

Conversation

geirolz
Copy link
Contributor

@geirolz geirolz commented Oct 31, 2021 •
edited
Loading

Hi, I'm trying to split my last PR (#1467) since it was too big.

With this PR i'd like to add some new Validators such:

Number

  • positive
  • positiveOrZero
  • negative
  • inRange

String

  • fixedLength
  • nonEmptyString

Collection

  • nonEmpty
  • fixedSize

Cats module

  • nonEmptyFoldable

@adamw
Copy link
Member

adamw commented Nov 1, 2021

Looks good, thank you! Only one question about the 0 :)

@geirolz geirolz force-pushed the Add_new_validators branch 3 times, most recently from 5972fad to 370c6b6 Compare November 1, 2021 10:01
@geirolz geirolz force-pushed the Add_new_validators branch from 370c6b6 to 17f0d91 Compare November 1, 2021 17:35
@adamw adamw merged commit 2a64630 into softwaremill:master Nov 1, 2021
@adamw
Copy link
Member

adamw commented Nov 1, 2021

Great, thank you! :)

@adamw adamw mentioned this pull request May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw adamw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geirolz @adamw