Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The derivedEnumeration macro should reference fully qualified class names #2255

Merged
merged 1 commit into from
Jun 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ private[tapir] object CodecEnumerationMacro {

// this needs to be a macro so that we can call another macro - Validator.derivedEnumeration
c.Expr[CreateDerivedEnumerationCodec[L, T]](q"""
new sttp.tapir.macros.CreateDerivedEnumerationCodec(Validator.derivedEnumeration)
new sttp.tapir.macros.CreateDerivedEnumerationCodec(sttp.tapir.Validator.derivedEnumeration)
""")
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package sttp.tapir.namespacing

import org.scalatest.flatspec.AnyFlatSpec
import org.scalatest.matchers.should.Matchers

class SchemaMacroNamespaceTest extends AnyFlatSpec with Matchers {

// #2254: the macro should reference fully qualified class names
it should "compile macro-generated code using derivedEnumeration in a package other than sttp.tapir" in {
sealed trait MyProduct
object MyProduct {
def fromString(m: String): Option[MyProduct] = ???
}
case object V1 extends MyProduct

import sttp.tapir.Codec
Codec.derivedEnumeration[String, MyProduct](MyProduct.fromString, _.toString)
}
}