Appending multiple variants #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamw There is no way to use multiple errorVariants using errorOutVariantPrepend. |
adamw
reviewed
Jan 5, 2024
| @@ -220,6 +220,10 @@ trait EndpointErrorOutputVariantsOps[A, I, E, O, -R] { | |||
| def errorOutVariantPrepend[E2 >: E](o: OneOfVariant[_ <: E2]): EndpointType[A, I, E2, O, R] = | |||
| withErrorOutputVariant(oneOf[E2](o, oneOfDefaultVariant(errorOutput)), identity) | |||
|
|
|||
| /** Same as [[errorOutVariantPrepend]], but allows appending multiple variants in one go. */ | |||
| def errorOutVariantPrepends[E2 >: E](first: OneOfVariant[_ <: E2], other: OneOfVariant[_ <: E2]*): EndpointType[A, I, E2, O, R] = | |||
There was a problem hiding this comment.
I think errorOutVariantsPrepend would be more grammatically correct?
There was a problem hiding this comment.
Thanks a lot @adamw . I changed the function name :)
|
Thanks, I left one comment in code :) |
Appending multiple variants Rename function name Fix errorOutVariantsPrepend compliation error
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.