-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add zio-http multipart body support #3690
feat: Add zio-http multipart body support #3690
Conversation
2090a02
to
8623fa2
Compare
@seakayone now that #3690 is merged, can you put up this PR for review? |
I am planning to finalize this PR in the next couple of days hopefully. |
64b870f
to
5488c26
Compare
There's some problems updating ZIO, I think we'll need to first tackle #3876, and then get back to this PR. Sorry for the problems :) |
Found the problem in zio-http: zio/zio-http#2977 |
Hello. @seakayone zio/zio-http#2977 was closed |
@adamw Is there anything blocking for this to be merged? The underlying bugs are resolved and we are waiting for this fix. Thanks! |
I'm guessing it's the same reason |
@seakayone can this PR be made public so it can be reviewed? |
Thanks for the work, needed a little push to get over the finish line, tests are now green :) |
Thank you, Adam, for all the work you do. |
@adamw Thanks for finalizing this. |
Resolves #2518
Currently tests fail because the incoming ServerRequest contains the multiple parts, but when calling zio.http.Request.body.[asMultipartFormStream|asMultiPartForm] they only ever return the single, first part.
Seems to be a bug in zio-http: zio/zio-http#2411
Bug was fixed and released. I have let the build run in my own actions and it succeded: https://github.com/seakayone/tapir/actions/runs/9943391610