Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix #112: Record email addresses from CFF #139

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

sdruskat
Copy link
Contributor

@sdruskat sdruskat commented Mar 16, 2023

This PR is a partial fix for #112, in that it uses the branch for this PR against cffconvert to record email addresses in CFF files.

Review checklist

  • Run
git fetch origin
git switch feature/record-cff-email
git pull
poetry shell
poetry install
pytest test/

... and all tests should pass.

  • Review changed files manually
  • Run HERMES against this local repo and check in the .hermes files if emails made it over from CFF.

@sdruskat sdruskat requested a review from led02 March 16, 2023 14:13
@sdruskat sdruskat marked this pull request as ready for review March 16, 2023 14:19
Copy link
Member

@led02 led02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: Just some minor cosmetics...

Copy link
Member

@led02 led02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Works for me (almost)

@zyzzyxdonta zyzzyxdonta merged commit 640da10 into develop Mar 16, 2023
@led02 led02 deleted the feature/record-cff-email branch May 3, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants