Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterative MNA solver #268

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

MarvinTollnitschRWTH
Copy link
Contributor

@MarvinTollnitschRWTH MarvinTollnitschRWTH commented Dec 5, 2023

This branch implements a solver capable of solving nonlinear circuit equation systems. The implemented solver class "IterativeMNASolverDirect" inherits from "MNASolverDirect" and adds a solving method which uses the Newton-Raphson iteration algorithm. To be usable by this solver, for all nonlinear component models an interface class is provided which expects the nonlinear component models to implement a method returning the model's Jacobian of its system matrix stamp for each time step to be used by the solver.

Since the Jacobian of a linear component's system matrix stamp is the stamp itself, linear component models such as the Resistive Companion implementations of components are usable with the new solver, also in combination with new nonlinear component models using the new interface.

Copy link

sonarcloud bot commented Dec 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 38 Code Smells

0.0% 0.0% Coverage
3.2% 3.2% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

1 similar comment
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@georgii-tishenin georgii-tishenin marked this pull request as draft June 27, 2024 08:31
+ add .h and .cpp for "IterativeMNASolverDirect " class, add .cpp to "dpsim/src/CMakeLists.txt"
+ add .h for new "MNANonlinearVariableCompInterface" class

* make "IterativeMNASolverDirect" usable through pybind by adding "ITERATIVEMNA" as value to solver type enum
* modify "Solver" class to support new "ITERATIVEMNA" solver type
* modify "Simulation" class to be able to create solvers of new type

Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
+ add .h and .cpp for new nonlinear "Diode" class which uses and inherits from the new "MNANonlinearVariableCompInterface"

* modify "Components.h" to include .h of new diode model
* modify "dpsim/dpsim-models/CMakeLists.txt" to include .cpp of new diode model
* modify "EMTComponents.cpp" to make new diode model usable through pybind

Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
+ add .cpp and python notebook for first diode example circuit
+ add python pybind notebook for second diode example circuit

* modify "dpsim/examples/cxx/CMakeLists.cpp" to include .cpp of first diode example circuit

Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@MarvinTollnitschRWTH MarvinTollnitschRWTH changed the title Nonlinear SSN Iterative MNA solver Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant