Addition of EMT::Ph1::Switch component #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinTollnitschRWTH
requested review from
m-mirz,
stv0g and
dinkelbachjan
as code owners
MarvinTollnitschRWTH
force-pushed
the
Ph1_Switch
branch
from
12d3731 to
0a4b0d6
Compare
gnakti
previously approved these changes
Jul 22, 2024
gnakti
force-pushed
the
Ph1_Switch
branch
2 times, most recently
from
79c3db7 to
c34650d
Compare
gnakti
approved these changes
Jul 22, 2024
georgii-tishenin
approved these changes
Jul 22, 2024
- added Ph1::Switch header and cpp files - added header to Components.h - added cpp to CMakeLists.txt - made Ph1::Switch usable in pybind by adding it in EMTComponents.cpp - added simple example circuit (VS_sw_R_L) for new EMT::Ph1::Switch model Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
- declare methods as "override" implementations - encapsulate system matrix stamps using "MNAStampUtils::stampConductance()" Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
reformatted files: - EMT_Ph1_Switch.h - EMT_Ph1_Switch.cpp Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
Signed-off-by: Ghassen Nakti <ghassen.nakti@eonerc.rwth-aachen.de>
Signed-off-by: Ghassen Nakti <ghassen.nakti@eonerc.rwth-aachen.de>
- increase simulation time to 2 seconds - add another switch event to close switch at 1.5 seconds - fix vs parameters by removing frequency for dp and sp domains - add assertions to check Ph1::EMT against Ph3::EMT, Ph1::EMT against dp and dp against sp Signed-off-by: Marvin Tollnitsch <marvin.tollnitsch@rwth-aachen.de>
|
m-mirz
approved these changes
Aug 16, 2024
|
Hm, the villas tests are failing due to docker compose missing. I don’t see how this could be related to the changes here. So, I will ignore the tests for the moment and we have to figure out later why they suddenly pop up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds: