Fix status bar accepting out of range indices

Resolves ValveSoftware/halflife#3242
sohl-modders · Apr 24, 2023 · 86d3496 · 86d3496
1 parent aca7506
commit 86d3496
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cl_dll/statusbar.cpp b/cl_dll/statusbar.cpp
@@ -233,7 +233,7 @@ int CHudStatusBar :: MsgFunc_StatusText( const char *pszName, int iSize, void *p
 
 	int line = READ_BYTE();
 
-	if ( line < 0 || line > MAX_STATUSBAR_LINES )
+	if (line < 0 || line >= MAX_STATUSBAR_LINES)
 		return 1;
 
 	strncpy( m_szStatusText[line], READ_STRING(), MAX_STATUSTEXT_LENGTH );
@@ -254,7 +254,7 @@ int CHudStatusBar :: MsgFunc_StatusValue( const char *pszName, int iSize, void *
 	BEGIN_READ( pbuf, iSize );
 
 	int index = READ_BYTE();
-	if ( index < 1 || index > MAX_STATUSBAR_VALUES )
+	if (index < 1 || index >= MAX_STATUSBAR_VALUES)
 		return 1; // index out of range
 
 	m_iStatusValues[index] = READ_SHORT();

diff --git a/dlls/osprey.cpp b/dlls/osprey.cpp
@@ -44,7 +44,7 @@ class COsprey : public CBaseMonster
 	int		Restore( CRestore &restore );
 	static	TYPEDESCRIPTION m_SaveData[];
 	int		ObjectCaps( void ) { return CBaseMonster :: ObjectCaps() & ~FCAP_ACROSS_TRANSITION; }
-	int  TakeDamage(entvars_t* pevInflictor, entvars_t* pevAttacker, float flDamage, int bitsDamageType) override;
+	int		TakeDamage(entvars_t* pevInflictor, entvars_t* pevAttacker, float flDamage, int bitsDamageType) override;
 
 	void Spawn( void );
 	void Precache( void );