[WIP]loadingの挙動を統一する #136
Open
[WIP]loadingの挙動を統一する #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying sos24-client with
|
| Latest commit: |
41d5475
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3527541.sos24-client.pages.dev |
| Branch Preview URL: | https://feat-swr-loading.sos24-client.pages.dev |
appare45
requested changes
Apr 9, 2024
|
あと、arataさんがDiscordでおっしゃてた通りの順番でマージする&メインブランチが変更されてたのでそれをこのブランチにマージして再チェックした方がいいかも |
|
ちょっと怖いのでもし対面のタイミングがあったら手伝ってもらえませんか... |
|
（appareくんから特に言いたいこととかがなければ）今日の夜とかにでも僕が対面で引き継げます 👍 |
Co-authored-by: Takaharu Nakamura <64473501+appare45@users.noreply.github.com>
Co-authored-by: Takaharu Nakamura <64473501+appare45@users.noreply.github.com>
Co-authored-by: Takaharu Nakamura <64473501+appare45@users.noreply.github.com>
Co-authored-by: Takaharu Nakamura <64473501+appare45@users.noreply.github.com>
見落としていました |
|
メモ: マージ時にベースブランチをdevelopに変更 |
|
あとでSWRからのデータのとり方の修正をします |
|
スケルトンを使うべきかもという話が上がっていますがどうしましょうか |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #112
close #56
とりあえずfalsyな値を使ってloadingを検知していた箇所をisLoadingを使うようにしました。
isLoadingの場合は何もないを返すようにしました。