Improve the readability of the SwrCache class #66
+201
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scheduling logic for batch tasks, originally implemented in the SwrCache class, has been extracted into a new class called BatchScheduler. This separation of concerns allows for better maintainability and reusability of code. Additionally, the SwrCachePolicy class has been moved to its own file. This separation of classes into individual files makes the codebase more navigable and easier to understand. refs: #44
ogaclejapan
added a commit
that referenced
this pull request
Aug 31, 2024
By making it a factory function, it is possible to defer creation until it is needed. refs: #66
ogaclejapan
added a commit
that referenced
this pull request
Aug 31, 2024
By making it a factory function, it is possible to defer creation until it is needed. refs: #66
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduling logic for batch tasks, originally implemented in the
SwrCacheclass, has been extracted into a new class calledBatchScheduler. This separation of concerns allows for better maintainability and reusability of code.Additionally, the
SwrCachePolicyclass has been moved to its own file. This separation of classes into individual files makes the codebase more navigable and easier to understand.refs: #44