Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdds 11784 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hdds 11784 #1

wants to merge 2 commits into from

Conversation

sokui
Copy link
Owner

@sokui sokui commented Dec 11, 2024

What changes were proposed in this pull request?

Provide a one-liner summary of the changes in the PR Title field above.
It should be in the form of HDDS-1234. Short summary of the change.

Please describe your PR in detail:

  • What changes are proposed in the PR? and Why? It would be better if it is written from third person's
    perspective not just for the reviewer.
  • Provide as much context and rationale for the pull request as possible. It could be copy-paste from
    the Jira's description if the jira is well defined.
  • If it is complex code, describe the approach used to solve the issue. If possible attach design doc,
    issue investigation, github discussion, etc.

Examples of well-written pull requests:

What is the link to the Apache JIRA

Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull
request which starts with the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)

(Please replace this section with the link to the Apache JIRA)

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)

@adoroszlai
Copy link

@sokui I think this PR in your fork was opened accidentally.

@sokui
Copy link
Owner Author

sokui commented Dec 13, 2024

@sokui I think this PR in your fork was opened accidentally.

I intentionally opened this to check how CI works. Will close afterwards.

@adoroszlai
Copy link

I intentionally opened this to check how CI works.

It's great that you check CI status. But opening a PR is not necessary to get CI feedback. CI checks are run for both push and pull_request events. Two workflow runs for the same commit:

push: https://github.com/sokui/ozone/actions/runs/12309831979
PR: https://github.com/sokui/ozone/actions/runs/12309832197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants