Fix ELF tests a bit #479
Merged
Fix ELF tests a bit #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 89.93% 89.96% +0.02%
==========================================
Files 23 23
Lines 10200 10200
==========================================
+ Hits 9173 9176 +3
+ Misses 1027 1024 -3
|
Lichtso
requested changes
Jul 2, 2023
| @@ -3128,17 +3128,6 @@ fn test_load_elf_rodata_sbpfv1() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Yep this is the default behaviour tested by test_load_elf_rodata now. And I added test_load_elf_rodata_sbpfv1 that checks the same without virtual addresses.
Fix the vaddr layout for sbpfv2 files. Add _sbpfv1 suffix to v1 tests.
alessandrod
force-pushed
the
elfs-fix
branch
2 times, most recently
from
c79c592
to
e724611
Compare
Lichtso
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the vaddr layout for sbpfv2 files. Add _sbpfv1 suffix to v1 tests.