Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - old Goblin ELF parser #551

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Cleanup - old Goblin ELF parser #551

merged 1 commit into from
Jul 3, 2024

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jan 26, 2024

No description provided.

src/elf.rs Outdated Show resolved Hide resolved
src/elf.rs Outdated Show resolved Hide resolved
src/elf.rs Show resolved Hide resolved
src/elf.rs Outdated Show resolved Hide resolved
@LucasSte
Copy link

LucasSte commented Jul 3, 2024

Instead of force pushing, try to make a new commit with the new changes in a PR. This facilitates the review.

* Removes the dependency "goblin".
* Removes the adapter traits.
* Inlines the trivial implementations and such that have only one call site.
Moves the rest to other files.
* Dissolves NewParser.
* Removes std::borrow::Cow.
@Lichtso Lichtso merged commit a4f7b40 into main Jul 3, 2024
12 checks passed
@Lichtso Lichtso deleted the cleanup/goblin branch July 3, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants