CI - Have test_code_length_estimate() test MACHINE_CODE_PER_INSTRUCTION_METER_CHECKPOINT
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 89.92% 90.07% +0.15%
==========================================
Files 22 22
Lines 9735 9713 -22
==========================================
- Hits 8754 8749 -5
+ Misses 981 964 -17 ☔ View full report in Codecov by Sentry. |
Lichtso
force-pushed
the
ci/test_code_length_estimate
branch
from
dd41ce7
to
15cada9
Compare
LucasSte
reviewed
Sep 25, 2024
Comment on lines
+1800
to
+1802
| machine_code_length as f64 / instruction_count as f64; | ||
| assert!( | ||
| machine_code_length_per_instruction <= MAX_MACHINE_CODE_LENGTH_PER_INSTRUCTION | ||
| (machine_code_length_per_instruction + 0.5) as usize |
There was a problem hiding this comment.
You don't need the floating point for the division. machine_code_length % instruction_count is always zero. In addition, our overestimation of MAX_MACHINE_CODE_LENGTH_PER_INSTRUCTION already covers the extra 0.5, so we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.