Fix return type of getTokenAccountsByDelegate/Owner #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
mcintyre94
force-pushed
the
cm-rpc-json-parsed
branch
from
e1c7eef
to
9d7b0d0
Compare
mcintyre94
force-pushed
the
cm-token-rpc-methods
branch
from
8d32071
to
e9b9724
Compare
buffalojoec
approved these changes
Jan 11, 2024
mcintyre94
force-pushed
the
cm-rpc-json-parsed
branch
3 times, most recently
from
2512cd1
to
87ffa63
Compare
mcintyre94
force-pushed
the
cm-token-rpc-methods
branch
from
e9b9724
to
0527e69
Compare
mcintyre94
force-pushed
the
cm-token-rpc-methods
branch
from
0527e69
to
9a93732
Compare
|
🎉 This PR is included in version 1.89.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Winds126
approved these changes
Jan 13, 2024
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These data stuctures were messed up, with the
TokenAccountnested under theprograminstead ofdataI've added typetests to verify the fix. I don't think we had these when we first wrote most of these methods, but they're better than the unit tests we have for rpc-methods TBH. Probably worth adding them at least where we find bugs!