-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate with max compute units, not u32::MAX #2728
Conversation
🦋 Changeset detectedLatest commit: 189659e The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 1.91.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Problem
Looking through recent updates to the monorepo, this caught my eye: anza-xyz/agave#885
The simulation utility sets
u32::MAX
, which will fail once that feature is enabled.Solution
Set
MAX_COMPUTE_UNITS
, hardcoded to 1,400,000, instead ofu32::MAX
.