stat for time spent copying generate index contents

solana-labs · Sep 8, 2023 · a02f41e · a02f41e
1 parent b588beb
commit a02f41e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/accounts-db/src/bucket_map_holder_stats.rs b/accounts-db/src/bucket_map_holder_stats.rs
@@ -63,6 +63,7 @@ pub struct BucketMapHolderStats {
     bins: u64,
     pub estimate_mem: AtomicU64,
     pub flush_should_evict_us: AtomicU64,
+    pub copy_us: AtomicU64,
 }
 
 impl BucketMapHolderStats {
@@ -516,6 +517,7 @@ impl BucketMapHolderStats {
                         .swap(0, Ordering::Relaxed),
                     i64
                 ),
+                ("copy_us", self.copy_us.swap(0, Ordering::Relaxed), i64),
             );
         } else {
             datapoint_info!(

diff --git a/accounts-db/src/in_mem_accounts_index.rs b/accounts-db/src/in_mem_accounts_index.rs
@@ -677,11 +677,13 @@ impl<T: IndexValue, U: DiskIndexValue + From<T> + Into<T>> InMemAccountsIndex<T,
         assert!(self.bucket.is_some());
 
         let mut insert = self.startup_info.insert.lock().unwrap();
-        // todo: memcpy the new slice into our vector already
-        // todo: avoid reallocs and just allocate another vec instead of likely resizing this one over and over
+        let m = Measure::start("copy");
         items
             .into_iter()
             .for_each(|(k, (slot, v))| insert.push((k, (slot, v.into()))));
+        self.stats()
+            .copy_us
+            .fetch_add(m.end_as_us(), Ordering::Relaxed);
     }
 
     pub fn insert_new_entry_if_missing_with_lock(