Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bad sig test to tpu.rs #231

Closed
garious opened this issue May 21, 2018 · 1 comment
Closed

Move bad sig test to tpu.rs #231

garious opened this issue May 21, 2018 · 1 comment

Comments

@garious
Copy link
Contributor

garious commented May 21, 2018

There's a test in thin_client.rs that ought to be in tpu.rs. It was put into the thin client module because that library makes it easy to create and send transactions to the server. It'd be even easier if we moved the TPU's composition of SigVerifyStage, BankingStage, and RecordStage into a a separate function. The you can use packet::to_packets() to create data for the packet_receiver channel, and then check for the expected out put on the signal_receiver. No need to mess with UDP sockets and potential timeouts.

fn test_bad_sig() {

@mvines mvines added this to the The Future! milestone Sep 5, 2018
@mvines
Copy link
Member

mvines commented May 4, 2019

test_bad_sig() no longer exists

@mvines mvines closed this as completed May 4, 2019
@rob-solana rob-solana removed this from the The Future! milestone May 21, 2019
lijunwangs pushed a commit to lijunwangs/solana that referenced this issue Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants