Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-token-sdk] Potential for a malicious prover to generate proofs over MAX_COMMITEMNTS (ottersec #7) #33525

Open
samkim-crypto opened this issue Oct 4, 2023 · 0 comments

Comments

@samkim-crypto
Copy link
Contributor

Problem

In Batched range proofs u64/u128/u256 the MaxCommitments are checked using if statement while creating a proof but not included in proof, which leads dishonest prover to prove a crafted proof which has over or greater than MaxCommitments by a verifier. The verifier needs to ensure the length of bit_lengths is less than MaxCommitments.

Proposed Solution

Add a check to verify bit_lengths in range proof verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant