-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zk-token-sdk] Add a length check on range proof commitment length #34165
[zk-token-sdk] Add a length check on range proof commitment length #34165
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34165 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 220122 220177 +55
=========================================
+ Hits 180386 180395 +9
- Misses 39736 39782 +46 |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer, thanks!
…34165) add a length check on range proof commitment length (cherry picked from commit e251b86) # Conflicts: # zk-token-sdk/src/errors.rs # zk-token-sdk/src/instruction/batched_range_proof/batched_range_proof_u128.rs # zk-token-sdk/src/instruction/batched_range_proof/batched_range_proof_u256.rs # zk-token-sdk/src/instruction/batched_range_proof/batched_range_proof_u64.rs
…ngth (backport of #34165) (#34182) * [zk-token-sdk] Add a length check on range proof commitment length (#34165) add a length check on range proof commitment length (cherry picked from commit e251b86) # Conflicts: # zk-token-sdk/src/errors.rs # zk-token-sdk/src/instruction/batched_range_proof/batched_range_proof_u128.rs # zk-token-sdk/src/instruction/batched_range_proof/batched_range_proof_u256.rs # zk-token-sdk/src/instruction/batched_range_proof/batched_range_proof_u64.rs * resolve conflict --------- Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>
Problem
#33525
Summary of Changes
When verifying range proof, I added a condition to check that the number of commitments are capped at
MAX_COMMITMENTS
.This is a split PR from #34065.
Fixes #