Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to portable isatty check #340

Closed
garious opened this issue Jun 12, 2018 · 0 comments
Closed

Migrate to portable isatty check #340

garious opened this issue Jun 12, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@garious
Copy link
Contributor

garious commented Jun 12, 2018

Instead of the isatty Linux/macOS-only dependency, how about:

https://github.com/softprops/atty
@garious garious added the good first issue Good for newcomers label Jun 12, 2018
@rlkelly rlkelly mentioned this issue Jun 13, 2018
Merged
@adamlaska adamlaska mentioned this issue Nov 17, 2023
Open
@adamlaska adamlaska mentioned this issue Dec 28, 2023
Open
@adamlaska adamlaska mentioned this issue Jan 5, 2024
Open
lijunwangs pushed a commit to lijunwangs/solana that referenced this issue Mar 21, 2024
@mergify @t-nelson
v1.17: rpc-sts: add config options for stake-weighted qos (backport of …
adc63fb 
…solana-labs#197) (solana-labs#340)

rpc-sts: add config options for stake-weighted qos (solana-labs#197)

* rpc-sts: plumb options for swqos config

* rpc-sts: send to specific tpu peers when configured

(cherry picked from commit f41fb84)

# Conflicts:
#	send-transaction-service/src/send_transaction_service.rs
#	validator/src/cli.rs
#	validator/src/main.rs

Co-authored-by: Trent Nelson <490004+t-nelson@users.noreply.github.com>
willhickey pushed a commit that referenced this issue Mar 23, 2024
@mergify @t-nelson @willhickey
v1.17: rpc-sts: add config options for stake-weighted qos (backport of …
845f0d4 
…#197) (#340)

rpc-sts: add config options for stake-weighted qos (#197)

* rpc-sts: plumb options for swqos config

* rpc-sts: send to specific tpu peers when configured

(cherry picked from commit f41fb84)

# Conflicts:
#	send-transaction-service/src/send_transaction_service.rs
#	validator/src/cli.rs
#	validator/src/main.rs

Co-authored-by: Trent Nelson <490004+t-nelson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garious