Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate ledger serialization code #517

Closed
garious opened this issue Jul 2, 2018 · 0 comments
Closed

Consolidate ledger serialization code #517

garious opened this issue Jul 2, 2018 · 0 comments
Assignees
@rob-solana
Milestone
v0.7.0

Comments

@garious
Copy link
Contributor

garious commented Jul 2, 2018

Move the serde_json::from_str code from bin/fullnode.rs and bank.rs into entry_writer.rs under new static methods read_entry() and read_entries().
@garious garious added this to the The Future! milestone Jul 2, 2018
garious added a commit to garious/solana that referenced this issue Jul 2, 2018
@garious
Consolidate ledger serialization code
771c1f4 
The new read_entries() works, but is overly-contrained. Not
using that function yet, but adding it here in the hopes some
Rust guru will tell us how to get that lifetime constraint out
of there.

Fixes solana-labs#517
@rob-solana rob-solana self-assigned this Jul 2, 2018
@garious garious closed this as completed in ec7e50b Jul 2, 2018
@garious garious modified the milestones: The Future!, v0.7.0 Jul 18, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@dankelleher
Expose Layouts and instruction creation functions to allow more flexi…
af98c77 
…ble use of the Token and TokenSwap clients. (solana-labs#517)
@masakazu12 masakazu12 mentioned this issue Mar 22, 2024
Open
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this issue Apr 1, 2024
@dependabot
build(deps): bump serde_json from 1.0.114 to 1.0.115 (solana-labs#517)
3c8da0d 
* build(deps): bump serde_json from 1.0.114 to 1.0.115

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.114 to 1.0.115.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.114...v1.0.115)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rob-solana rob-solana

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
2 participants
@garious @rob-solana