budget_contract: Remove Signature from ApplySignature #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
approved these changes
Sep 19, 2018
| } | ||
|
|
||
| #[derive(Serialize, Deserialize, Debug, Clone, Default, PartialEq)] | ||
| pub struct BudgetContract { | ||
| pub initialized: bool, | ||
| pub pending: HashMap<Signature, Plan>, | ||
| pub pending_plan: Option<Plan>, |
There was a problem hiding this comment.
My favorite line of code today.
There was a problem hiding this comment.
srsly, this line made me 😸 too!
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…1260) Bumps [solana-cli-config](https://github.com/solana-labs/solana) from 1.5.6 to 1.5.8. - [Release notes](https://github.com/solana-labs/solana/releases) - [Changelog](https://github.com/solana-labs/solana/blob/master/RELEASE.md) - [Commits](solana-labs/solana@v1.5.6...v1.5.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
alessandrod
pushed a commit
to alessandrod/solana
that referenced
this pull request
May 13, 2024
* ci: source based coverage * point to file explorer * fix sanity * break line * pass @ arg from ci/coverage to script/coverage * move source script to the top * direct to the summary page * explain why nightly * don't rug orignal rustflag * rearrange args order * bring back the trace level logging * remove _ * fix log level * add reference to envs * put cov result into target/cov * move output to target/cov * XXX hack buildkite pipeline * XXX: test for no log * Revert "XXX hack buildkite pipeline" This reverts commit effb72e. * Revert "XXX: test for no log" This reverts commit 975482d. * don't use trace log level temporarily * only search coverage report in the main folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's vestigial now that each budget contract has its own distinct state