sort local interfaces before selecting one #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Sep 19, 2018
src/netutil.rs
Outdated
| for iface in datalink::interfaces() { | ||
| let mut ifaces = datalink::interfaces(); | ||
|
|
||
| // put eth0 and wifi0, etc. up front of our list of candidates |
There was a problem hiding this comment.
Can you move everything from here on down into a separate function and add tests for it?
rob-solana
force-pushed
the
network-select
branch
from
6380ccd
to
4c5edbf
Compare
|
happens to be what my WSL box looks like when I'm at WeWork (save the phony "eth0") |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
solana-labs#1273) Bumps [flow-typed](https://github.com/flow-typed/flow-typed) from 3.2.1 to 3.3.1. - [Release notes](https://github.com/flow-typed/flow-typed/releases) - [Changelog](https://github.com/flow-typed/flow-typed/blob/master/CHANGELOG.md) - [Commits](flow-typed/flow-typed@v3.2.1...v3.3.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2501babe
pushed a commit
to 2501babe/solana
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1101