Fix bad ancestor check #17401
Merged
Fix bad ancestor check #17401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17401 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 424 424
Lines 118444 118454 +10
=========================================
+ Hits 97994 98000 +6
- Misses 20450 20454 +4 |
jstarry
approved these changes
May 22, 2021
|
Thanks! |
ryoqun
reviewed
May 23, 2021
Comment on lines
+797
to
+801
| // However, there is also the possibility that `last_voted_slot` is a stray, in which | ||
| // case we cannot make this conclusion as we do not know the ancestors/descendants | ||
| // of strays. Hence we err on the side of caution here and ignore this vote. This | ||
| // is ok because validators voting on different unrooted forks should eventually vote | ||
| // on some descendant of the root, at which time they can be included in switching proofs. |
There was a problem hiding this comment.
@carllin 👍 thanks for defending/maintaining the persistent tower. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Slot voted for in gossip may have been purged by a root by the time the switch threshold check is made
Summary of Changes
If the gossip vote is not in BankForks, don't include it in the switch threshold check
Fixes #17377