Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min/max bin size metrics to hash calculation #18155

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Jun 22, 2021

Problem

Binning shows up in several places already. It is useful to keep track of the current distribution of pubkeys.

Summary of Changes

Log min/max bin size after we calculate hash and lamports.
Fixes #

@jeffwashington
Copy link
Contributor Author

61M mnb snapshot:

calculate_accounts_hash_without_index accounts_scan=2172165i eliminate_zeros=1013083i hash=227026i hash_time_pre_us=226921i sort=3869011i hash_total=61837228i storage_sort_us=938i unreduced_entries=62830071i collect_snapshots_us=63446i num_snapshot_storage=372887i min_bin_size=824i max_bin_size=1131i total=7345669i

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #18155 (3ed422a) into master (d3ee73e) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #18155     +/-   ##
=========================================
- Coverage    82.3%    82.3%   -0.1%     
=========================================
  Files         433      433             
  Lines      120880   120886      +6     
=========================================
- Hits        99592    99555     -37     
- Misses      21288    21331     +43     

@jeffwashington jeffwashington marked this pull request as ready for review June 23, 2021 17:31
Copy link
Contributor

@jbiseda jbiseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jeffwashington jeffwashington merged commit 77c3ffe into solana-labs:master Jun 23, 2021
mergify bot pushed a commit that referenced this pull request Jun 23, 2021
mergify bot added a commit that referenced this pull request Jun 23, 2021
(cherry picked from commit 77c3ffe)

Co-authored-by: Jeff Washington (jwash) <75863576+jeffwashington@users.noreply.github.com>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants