Cli epoch-info: generate epoch-completed time from block times #18258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
reviewed
Jun 28, 2021
CriesofCarrots
force-pushed
the
epoch-completed-time
branch
from
9e5f96c
to
ef9369d
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Generate epoch-completed time from block times * Add annotation when block times not available (cherry picked from commit f2b0d56)
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Generate epoch-completed time from block times * Add annotation when block times not available (cherry picked from commit f2b0d56)
CriesofCarrots
added a commit
that referenced
this pull request
Jun 28, 2021
This was referenced Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana epoch-infouses recent performance samples to estimate the epoch's elapsed and total times. However, the samples only cover the last hour. This is a good enough estimate for the remaining epoch time, but we actually know the elapsed epoch time from the block times.Summary of Changes
Use block times for the epoch-start and current Slots to calculate epoch-completed time and refine the total epoch time estimate.
Fixes #17472