Remove KeyedAccount in builtin program "BPF loader"
#24381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everywhere except for DeployWithMaxDataLen and Upgrade.
In DeployWithMaxDataLen and Upgrade.
Codecov Report
@@ Coverage Diff @@
## master #24381 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 582 582
Lines 162041 162462 +421
=========================================
+ Hits 133132 133435 +303
- Misses 28909 29027 +118 |
|
@codecov[bot] is not allowed to run commands |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
) * Uses transaction_context.get_key_of_account_at_index() when only the key is needed. * Uses "!instruction_context.is_signer()" instead of ".signer_key().is_none()". * Uses instruction_context.get_index_in_transaction() to detect account aliasing. * Makes sure that there is only one KeyedAccount at a time. Everywhere except for DeployWithMaxDataLen and Upgrade. * Makes sure that there is only one KeyedAccount at a time. In DeployWithMaxDataLen and Upgrade. * Replaces KeyedAccount by BorrowedAccount. * Removes unused code.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
) * Uses transaction_context.get_key_of_account_at_index() when only the key is needed. * Uses "!instruction_context.is_signer()" instead of ".signer_key().is_none()". * Uses instruction_context.get_index_in_transaction() to detect account aliasing. * Makes sure that there is only one KeyedAccount at a time. Everywhere except for DeployWithMaxDataLen and Upgrade. * Makes sure that there is only one KeyedAccount at a time. In DeployWithMaxDataLen and Upgrade. * Replaces KeyedAccount by BorrowedAccount. * Removes unused code.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
) * Uses transaction_context.get_key_of_account_at_index() when only the key is needed. * Uses "!instruction_context.is_signer()" instead of ".signer_key().is_none()". * Uses instruction_context.get_index_in_transaction() to detect account aliasing. * Makes sure that there is only one KeyedAccount at a time. Everywhere except for DeployWithMaxDataLen and Upgrade. * Makes sure that there is only one KeyedAccount at a time. In DeployWithMaxDataLen and Upgrade. * Replaces KeyedAccount by BorrowedAccount. * Removes unused code.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
) * Uses transaction_context.get_key_of_account_at_index() when only the key is needed. * Uses "!instruction_context.is_signer()" instead of ".signer_key().is_none()". * Uses instruction_context.get_index_in_transaction() to detect account aliasing. * Makes sure that there is only one KeyedAccount at a time. Everywhere except for DeployWithMaxDataLen and Upgrade. * Makes sure that there is only one KeyedAccount at a time. In DeployWithMaxDataLen and Upgrade. * Replaces KeyedAccount by BorrowedAccount. * Removes unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Builtin programs still use
KeyedAccount.Summary of Changes
KeyedAccountbyBorrowedAccount.keyed_account.signer_key()byinstruction_context.is_signer().transaction_context.get_key_of_account_at_index()when only the key is needed.