Remove tick counting from broadcast service #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
force-pushed
the
entry_sender_with_height
branch
from
4d15a71
to
59c8438
Compare
Codecov Report
@@ Coverage Diff @@
## master #2934 +/- ##
========================================
- Coverage 78.3% 78.3% -0.1%
========================================
Files 126 126
Lines 19625 19567 -58
========================================
- Hits 15371 15323 -48
+ Misses 4254 4244 -10 |
aeyakovenko
changed the title
aeyakovenko
added
the
automerge
garious
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Poh recorder controls the ticks that are sent to the bank, and therefore the broadcast service doesn't need to do any counting, and any counting it does right now doesn't seem to be in sync.
Summary of Changes
Send the tick_height with the Entry or Tick.
Fixes #
tag: @sagar-solana @carllin (very wip)