Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_parents() => squash() #2943

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

rob-solana
Copy link
Contributor

No description provided.

Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks

@rob-solana
Copy link
Contributor Author

I did it for me. Carl and I, when talking, kept using "merge_from_parents()", which is the forkering terminology, and is waay wrong for current code base

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2943 into master will decrease coverage by <.1%.
The diff coverage is 89.4%.

@@           Coverage Diff            @@
##           master   #2943     +/-   ##
========================================
- Coverage    78.3%   78.3%   -0.1%     
========================================
  Files         126     126             
  Lines       19604   19603      -1     
========================================
- Hits        15352   15351      -1     
  Misses       4252    4252

1 similar comment
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2943 into master will decrease coverage by <.1%.
The diff coverage is 89.4%.

@@           Coverage Diff            @@
##           master   #2943     +/-   ##
========================================
- Coverage    78.3%   78.3%   -0.1%     
========================================
  Files         126     126             
  Lines       19604   19603      -1     
========================================
- Hits        15352   15351      -1     
  Misses       4252    4252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants