pull leader_scheduler out of process_entries() #2953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
requested review from
mvines and
garious
and removed request for
mvines
garious
approved these changes
Feb 26, 2019
rob-solana
force-pushed
the
hoist-leader_scheduler
branch
from
73b630d
to
cbeca20
Compare
Codecov Report
@@ Coverage Diff @@
## master #2953 +/- ##
========================================
- Coverage 78.3% 78.3% -0.1%
========================================
Files 127 127
Lines 19735 19631 -104
========================================
- Hits 15459 15374 -85
+ Misses 4276 4257 -19 |
|
rebased |
rob-solana
force-pushed
the
hoist-leader_scheduler
branch
from
cbeca20
to
498c0d6
Compare
|
superseded by #2962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cleanup of replay_stage is complicated by propagation of leader_scheduler to layers that
don't need to touch it
Summary of Changes
pull leader_scheduler up a level (or two)