Update the RPC bank on fullnode rotation #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
approved these changes
Feb 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #2956 +/- ##
========================================
Coverage ? 78.2%
========================================
Files ? 127
Lines ? 19687
Branches ? 0
========================================
Hits ? 15411
Misses ? 4276
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another 🍪 from #2884.
The RPC bank needs to be updated regularly by the Tvu as it processes and freezes banks, to ensure RPC continues to serve recent results back to clients.
This is only a partial solution to this problem, by plumbing the mechanism to perform the bank updates. What's missing still (from #2884) is an update to the Tvu rotation signal to share a recently frozen bank back with fullnode so it can update the RPC. Until that's in place fullnode just gives the RPC the working bank, which is no less broken than what it currently does.