Squash test to test parent bank after squash #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
squash-test
branch
from
599a127
to
9330682
Compare
3 tasks
|
this isn't covered by the tests in accounts? |
|
ah, different Accounts impl ;) |
|
@rob-solana not that i know of, but I admit I didn't look at your recent PR too closely yet to see if that does it. |
Codecov Report
@@ Coverage Diff @@
## master #2961 +/- ##
========================================
- Coverage 78.3% 78.3% -0.1%
========================================
Files 127 127
Lines 19705 19697 -8
========================================
- Hits 15447 15435 -12
- Misses 4258 4262 +4 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2961 +/- ##
========================================
- Coverage 78.3% 78.3% -0.1%
========================================
Files 127 127
Lines 19705 19697 -8
========================================
- Hits 15447 15435 -12
- Misses 4258 4262 +4 |
|
@rob-solana no I don't see any test that tests that the parent bank is ok after squash. |
garious
approved these changes
Feb 26, 2019
|
my test of accountsdb_squash verifies that the previous db is ok after squash() |
|
but more tests mo-better ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing test for when a parent's account set is still valid after a child squash.
Summary of Changes
Add a test for this scenario. Impetus is that the persistant accounts PR does not pass this test yet and that causes problems when the bank the RPC module is looking at doesn't match the one that is the latest which has been squashed.
Fixes #