dcou: mod banking_trace::for_test #32428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Jul 9, 2023
Comment on lines
-7
to
-10
| solana_perf::{ | ||
| packet::{to_packet_batches, PacketBatch}, | ||
| test_tx::test_tx, | ||
| }, |
There was a problem hiding this comment.
feels so good these dev related uses are removed from root use. :)
ryoqun
force-pushed
the
dcou-banking-trace-for-test
branch
from
f65b841
to
d6efeb3
Compare
Codecov Report
@@ Coverage Diff @@
## master #32428 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 778 778
Lines 210200 210200
=======================================
+ Hits 172591 172607 +16
+ Misses 37609 37593 -16 |
ryoqun
commented
Jul 10, 2023
core/Cargo.toml
Outdated
Comment on lines
81
to
84
| # Even if we want to activate features only for dev-dep., `cargo publish` | ||
| # complains about self-dep with version specified. So don't inherit with | ||
| # `workspace = true`. In this way, `cargo publish` will strip this self-dep | ||
| # according to https://github.com/rust-lang/cargo/pull/7333 | ||
| solana-core = { path = ".", features = ["dev-context-only-utils"] } |
ryoqun
force-pushed
the
dcou-banking-trace-for-test
branch
from
66713dd
to
9e26838
Compare
ryoqun
force-pushed
the
dcou-banking-trace-for-test
branch
from
eb4d59c
to
a61b291
Compare
Thanks for the poke. I had seen this previously, but saw the blocking PR which was a lot bigger and touching stuff I wasn't familiar with. Then I immediately forgot this existed 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is the 3rd use of the shiny
dev-context-only-utils, introduced at #32169)Finally, i atone for another sin at #29196... lol
currently, blocked by #32432(EDIT: unblocked now)