Bugfix: would_be_leader_shortly_fn period set to 1 slot instead of 20 #32468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
commented
Jul 12, 2023
| @@ -53,8 +53,10 @@ impl DecisionMaker { | |||
| }) | |||
| }, | |||
| || { | |||
| poh_recorder | |||
| .would_be_leader(HOLD_TRANSACTIONS_SLOT_OFFSET * DEFAULT_TICKS_PER_SLOT) | |||
| poh_recorder.would_be_leader( | |||
There was a problem hiding this comment.
this is would_be_leader_shortly_fn.
apfitzge
changed the title
Codecov Report
@@ Coverage Diff @@
## master #32468 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 778 778
Lines 210200 210200
=========================================
- Hits 172640 172592 -48
- Misses 37560 37608 +48 |
carllin
approved these changes
Jul 12, 2023
Exactly. The pattern we use to have (and want) is: the bug makes it so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#30618 did a bad copy pasta of constants.
Found this while investigating #32179 further, added some notes there on investigation.
#30618 was originally merged into v1.16. I reccommend we backport this.
My intent is to keep this fix PR simple so that it can be backported, and add tests to master in a follow-up PR.
Summary of Changes
revert constant for HOLD-only period from 20 slots to 1 slot.
Fixes #