Fix - missing delay visibility feature triggering cache flush #32974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
added
bug
Codecov Report
@@ Coverage Diff @@
## master #32974 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 784 784
Lines 212650 212650
=======================================
+ Hits 174379 174385 +6
+ Misses 38271 38265 -6 |
pgarg66
approved these changes
Aug 24, 2023
Lichtso
deleted the
fix/missing_delay_visibility_feature_triggering_cache_flush
branch
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
Adds delay_visibility_of_program_deployment to FEATURES_AFFECTING_RBPF. (cherry picked from commit 025b952) # Conflicts: # runtime/src/bank.rs
Lichtso
added a commit
that referenced
this pull request
Aug 24, 2023
Adds delay_visibility_of_program_deployment to FEATURES_AFFECTING_RBPF. (cherry picked from commit 025b952)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The feature
delay_visibility_of_program_deploymentshould also trigger a flush of theLoadedProgramscache.Summary of Changes
Adds
delay_visibility_of_program_deploymenttoFEATURES_AFFECTING_RBPFinBank::apply_builtin_program_feature_transitions().