-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor - Move interfaces of address-lookup-table into the program SDK #33165
Refactor - Move interfaces of address-lookup-table into the program SDK #33165
Conversation
d00b963
to
f5dde5d
Compare
6537ec4
to
d4f9f46
Compare
Codecov Report
@@ Coverage Diff @@
## master #33165 +/- ##
=========================================
- Coverage 82.0% 81.9% -0.2%
=========================================
Files 785 785
Lines 211122 212603 +1481
=========================================
+ Hits 173328 174156 +828
- Misses 37794 38447 +653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better organization, imo! just a couple deprecation nits
d4f9f46
to
bf54c55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! i'm r+ now. ping me if no one dissents or approves in 24hrs and i'll approve
Thanks for preserving the existing public interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
Unlike the other built-in programs the address-lookup-table does not have a module in the program SDK. Instead other crates which depend on it use its program crate directly, which leads to dependency bloat: E.g. they implicitly also gain the entire program-runtime as a transitive dependency.
Summary of Changes
Moves
error
,state
andinstruction
of address-lookup-table from its program crate into the program SDK.