Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Move interfaces of address-lookup-table into the program SDK #33165

Merged

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Sep 6, 2023

Problem

Unlike the other built-in programs the address-lookup-table does not have a module in the program SDK. Instead other crates which depend on it use its program crate directly, which leads to dependency bloat: E.g. they implicitly also gain the entire program-runtime as a transitive dependency.

Summary of Changes

Moves error, state and instruction of address-lookup-table from its program crate into the program SDK.

@Lichtso Lichtso force-pushed the refactor/move_address_lookup_table_into_sdk branch 3 times, most recently from d00b963 to f5dde5d Compare September 6, 2023 17:57
@Lichtso Lichtso force-pushed the refactor/move_address_lookup_table_into_sdk branch 3 times, most recently from 6537ec4 to d4f9f46 Compare September 6, 2023 19:41
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #33165 (bf54c55) into master (5573a61) will decrease coverage by 0.2%.
Report is 19 commits behind head on master.
The diff coverage is 83.1%.

@@            Coverage Diff            @@
##           master   #33165     +/-   ##
=========================================
- Coverage    82.0%    81.9%   -0.2%     
=========================================
  Files         785      785             
  Lines      211122   212603   +1481     
=========================================
+ Hits       173328   174156    +828     
- Misses      37794    38447    +653     

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better organization, imo! just a couple deprecation nits

sdk/program/src/address_lookup_table_account.rs Outdated Show resolved Hide resolved
programs/address-lookup-table/src/lib.rs Show resolved Hide resolved
@Lichtso Lichtso force-pushed the refactor/move_address_lookup_table_into_sdk branch from d4f9f46 to bf54c55 Compare September 6, 2023 21:24
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! i'm r+ now. ping me if no one dissents or approves in 24hrs and i'll approve

@CriesofCarrots
Copy link
Contributor

Thanks for preserving the existing public interface

@t-nelson t-nelson self-requested a review September 11, 2023 18:39
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Lichtso Lichtso merged commit bbb57be into solana-labs:master Sep 11, 2023
27 checks passed
@Lichtso Lichtso deleted the refactor/move_address_lookup_table_into_sdk branch September 11, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants