Enable the banking trace by default #33497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Oct 3, 2023
| @@ -1134,11 +1134,11 @@ impl Validator { | |||
| .map_err(|err| format!("{} [{:?}]", &err, &err))?; | |||
| if banking_tracer.is_enabled() { | |||
| info!( | |||
| "Enabled banking tracer (dir_byte_limit: {})", | |||
| "Enabled banking trace (dir_byte_limit: {})", | |||
There was a problem hiding this comment.
just let's be consistent with cli terms.
Codecov Report
@@ Coverage Diff @@
## master #33497 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 802 802
Lines 217779 217781 +2
=========================================
- Hits 178111 178091 -20
- Misses 39668 39690 +22 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit eb262aa)
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The banking trace disabled code path is running fine with mb & v1.16.
Let's bake the banking trace with v1.17 rel train to enable it on mb by default eventually.
I'm procrastinator.. missed v1.17 branching a day.
Summary of Changes
Enable it by default.
CLI: