Remove dummy entries in Blockstore special columns #33511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These entries were found to improve compaction performance when ledger compaction was done by LedgerCleanupService on a primary index. Cleaning by primary index has been deprecated for a while, and these dummy entries are no longer needed.
steviez
changed the title
CriesofCarrots
approved these changes
Oct 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #33511 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 802 802
Lines 217835 217832 -3
=======================================
+ Hits 178123 178137 +14
+ Misses 39712 39695 -17 |
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Oct 6, 2023
These entries were found to improve compaction performance when LedgerCleanupService was performing direct compactions on each primary index. Cleaning by primary index has been deprecated for a while, and as such, these dummy entries are no longer needed and can be removed.
|
Dang, I just realized this commit won't function as intended. The function that removes the dummy entries only gets called if the TransactionStatusIndex entries are not populated. Those entries will only be absent on a brand new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These entries were found to improve compaction performance when
LedgerCleanupService was performing direct compactions on each primary
index. Cleaning by primary index has been deprecated for a while, and
as such, these dummy entries are no longer needed and can be removed.
Summary of Changes
Remove the dummy entries + a few comments that will no longer be correct
This is broken out from #33370