initialize with new VoteState for tests #33518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33518 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 802 802
Lines 217872 217874 +2
=======================================
+ Hits 178144 178161 +17
+ Misses 39728 39713 -15 |
AshwinSekar
force-pushed
the
vote-state-init
branch
from
4fb744d
to
5889e02
Compare
bji
approved these changes
Oct 4, 2023
steveluscher
approved these changes
Oct 4, 2023
|
Should this get backported to 1.17 at least? |
|
ah yeah good call |
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit d4941cc)
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that clusters are on 1.16 and the feature flag is set to be activated soon, it's fine to use the new vote state format for tests.
Summary of Changes
Update with new vote state format for tests. Should not affect any live functionality.
Fixes #33517