Uses IntSet for RootsTracker::uncleaned_roots
#33524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
nohash/roots-tracker
branch
from
c8830ec
to
d152d68
Compare
brooksprumo
added
CI
Codecov Report
@@ Coverage Diff @@
## master #33524 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.2%
=========================================
Files 766 803 +37
Lines 209028 217899 +8871
=========================================
+ Hits 171148 178176 +7028
- Misses 37880 39723 +1843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#33521 added
solana-nohash-hasher.RootsTracker::uncleaned_rootsis a list of slots, and doesn't need to be cryptographically secure. This will make inserting/looking up roots to clean faster.Summary of Changes
Uses
IntSetforRootsTracker::uncleaned_roots