Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update feature gate no-op program id #33535

Merged

Conversation

buffalojoec
Copy link
Contributor

Problem

The no-op program intended to replace the empty account Feature11111111111111 was only deployed to mainnet-beta. I've deployed it to all clusters but it required a new program ID.

Summary of Changes

Updates the no-op program's ID in the feature activation to 37Yr1mVPdfUuy6oC2yPjWtg8xyyVi33TYYqyNQocsAkT.

See updated README with verifiable build information: https://github.com/buffalojoec/noop-programs/tree/main/programs/feature-gate-noop

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #33535 (7dd6ba5) into master (c66af12) will increase coverage by 0.0%.
Report is 2 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33535   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         805      805           
  Lines      218111   218111           
=======================================
+ Hits       178323   178379   +56     
+ Misses      39788    39732   -56     

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dumped both programs and confirm that they are byte-for-byte the same, looks good!

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not confirm the verifiable build, but I trust @joncinque :)
I recommend merging #33527 before this one to save yourself a rebase.

@buffalojoec buffalojoec merged commit 93d8bcc into solana-labs:master Oct 5, 2023
31 checks passed
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
willhickey pushed a commit that referenced this pull request Oct 6, 2023
)

update feature gate no-op program id (#33535)

(cherry picked from commit 93d8bcc)

Co-authored-by: Joe C <jcaulfield135@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants