Add early return to Blockstore::find_address_signatures methods #33545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
changed the title
steviez
approved these changes
Oct 5, 2023
CriesofCarrots
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
CriesofCarrots
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spin off from #33419. In the case of both
find_address_signatures_for_slotandfind_address_signatures, there is no reason to read from Blockstore when the slot in question (or range of slots in question, respectively) has already been purged from the ledger.Summary of Changes
Add early return to
find_address_signatures_for_slotandfind_address_signaturesbased onlowest_available_slot