Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses stable u64::next_multiple_of() #33549

Merged

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Oct 5, 2023

Problem

We copied the impl of next_multiple_of into our codebase because it was not stable yet. With Rust 1.73.0, that has changed! We can use the stable version of next_multiple_of from std instead.

Summary of Changes

Use the stable version, and removes ours.

@brooksprumo brooksprumo added the noCI Suppress CI on this Pull Request label Oct 5, 2023
@brooksprumo brooksprumo self-assigned this Oct 5, 2023
@brooksprumo brooksprumo added CI Pull Request is ready to enter CI and removed noCI Suppress CI on this Pull Request labels Oct 6, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Oct 6, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 6, 2023 16:49
@brooksprumo brooksprumo merged commit c8d545c into solana-labs:master Oct 6, 2023
31 checks passed
@brooksprumo brooksprumo deleted the rust/1.73.0/next-multiple-of branch October 6, 2023 17:45
@brooksprumo brooksprumo added the v1.17 PRs that should be backported to v1.17 label Oct 6, 2023
mergify bot pushed a commit that referenced this pull request Oct 6, 2023
mergify bot added a commit that referenced this pull request Oct 6, 2023
…3567)

Uses stable `u64::next_multiple_of()` (#33549)

(cherry picked from commit c8d545c)

Co-authored-by: Brooks <brooks@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants