Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashes per tick with feature gates #33600

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

bw-solana
Copy link
Contributor

@bw-solana bw-solana commented Oct 9, 2023

Problem

Add 5 additional feature gates to be able to gradually ramp up required hashes per tick to keep validators busier based on analysis in https://docs.google.com/spreadsheets/d/1NDJZiSFxqbVIi0jn-7I7MrYN2lqP4j9GePZdyPZ1fhI/edit#gid=1060803070

Summary of Changes

Current hashes per tick is at 2M. Add features to step this up on epoch boundaries to:

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #33600 (36566e4) into master (fa21a3d) will decrease coverage by 0.1%.
Report is 2 commits behind head on master.
The diff coverage is 100.0%.

❗ Current head 36566e4 differs from pull request most recent head 34d7336. Consider uploading reports for the commit 34d7336 to get more accurate results

@@            Coverage Diff            @@
##           master   #33600     +/-   ##
=========================================
- Coverage    81.8%    81.7%   -0.1%     
=========================================
  Files         806      807      +1     
  Lines      217477   218329    +852     
=========================================
+ Hits       178026   178531    +505     
- Misses      39451    39798    +347     

sdk/src/feature_set.rs Outdated Show resolved Hide resolved
t-nelson
t-nelson previously approved these changes Oct 11, 2023
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ feature gate string udpates

bp to 1.17?

@bw-solana
Copy link
Contributor Author

r+ feature gate string udpates

bp to 1.17?

Yep, I can backport

bw-solana and others added 2 commits October 11, 2023 08:57
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
@bw-solana bw-solana added the v1.17 PRs that should be backported to v1.17 label Oct 11, 2023
@bw-solana bw-solana merged commit b36d051 into solana-labs:master Oct 11, 2023
39 of 41 checks passed
mergify bot pushed a commit that referenced this pull request Oct 11, 2023
* Update hashes per tick with feature gates

(cherry picked from commit b36d051)
bw-solana added a commit that referenced this pull request Oct 11, 2023
…#33661)

Update hashes per tick with feature gates (#33600)

* Update hashes per tick with feature gates

(cherry picked from commit b36d051)

Co-authored-by: Brennan <brennan.watt@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants