Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dated Blockstore PurgeType::PrimaryIndex code #33631

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Oct 10, 2023

Problem

Purging the blockstore with PurgeType::PrimaryIndex has been dated for quite a while.

Summary of Changes

  • Update instances of PurgeType::PrimaryIndex to PurgeType::Exact
  • Remove now unused functions
  • Remove unused active_transaction_status_index field

@steviez steviez changed the title Remove data Blockstore PurgeType::PrimaryIndex code Remove unused Blockstore PurgeType::PrimaryIndex code Oct 10, 2023
@steviez steviez changed the title Remove unused Blockstore PurgeType::PrimaryIndex code Remove dated Blockstore PurgeType::PrimaryIndex code Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #33631 (c1908ec) into master (982d29c) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #33631     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217499   217445     -54     
=========================================
- Hits       178019   177973     -46     
+ Misses      39480    39472      -8     

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@steviez steviez merged commit 33e1dd7 into solana-labs:master Oct 10, 2023
16 checks passed
@steviez steviez deleted the bstore_rm_purge_primary_index branch October 10, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants