Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archive_format.rs #33640

Closed
wants to merge 1 commit into from
Closed

Conversation

stakrspace
Copy link

Problem

Argument errors for solana-validator v1.17.0 & v1.17.1 specifying '--snapshot-archive-format '

Running v1.17.1 produces error for any mentioned archive format lz4 or zstd - error: 'none' isn't a valid value for '--snapshot-archive-format <ARCHIVE_TYPE>' [possible values: lz4, zstd]

Running v1.17.0 gives error: The argument '--snapshot-archive-format <ARCHIVE_TYPE>' was provided more than once, but cannot be used multiple times

Summary of Changes

return back line for "tar" | "none" => Some(ArchiveFormat::Tar),

Fixes #
the command line argument for lz4/zstd needs to be accepted as well

Problem

Argument errors for solana-validator v1.17.0 & v1.17.1 specifying '--snapshot-archive-format '

Running v1.17.1 produces error for any mentioned archive format lz4 or zstd - error: 'none' isn't a valid value for '--snapshot-archive-format <ARCHIVE_TYPE>' [possible values: lz4, zstd]

Running v1.17.0 gives error: The argument '--snapshot-archive-format <ARCHIVE_TYPE>' was provided more than once, but cannot be used multiple times

Summary of Changes

return back line for "tar" | "none" => Some(ArchiveFormat::Tar),

Fixes #
the command line argument for lz4/zstd needs to be accepted as well
@mergify mergify bot added community Community contribution need:merge-assist labels Oct 10, 2023
@mergify mergify bot requested a review from a team October 10, 2023 21:31
@steviez
Copy link
Contributor

steviez commented Oct 10, 2023

Running v1.17.1 produces error for any mentioned archive format lz4 or zstd - error: 'none' isn't a valid value for '--snapshot-archive-format <ARCHIVE_TYPE>' [possible values: lz4, zstd]

The options none / tar / bz2 / gzip were removed intentionally per #33484; the only options we will support in the future are lz4 and zstd. The change to disallow these types was first introduced in v1.17.1, so that is why you don't see the same error in v1.17.0. I have personally verified that passing zstd or lz4 works with v1.17.1, as does not specifying --snapshot-archive-format at all

Running v1.17.0 gives error: The argument '--snapshot-archive-format <ARCHIVE_TYPE>' was provided more than once, but cannot be used multiple times

That error is unrelated to version and is telling you directly what the problem is - you specified that argument more than once.

@steviez steviez closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants