Bump solana_rbpf to v0.8.0 #33679
Merged
Bump solana_rbpf to v0.8.0 #33679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
solana_rbpf/v0.8.0
branch
11 times, most recently
from
0b91224
to
7989aa6
Compare
Lichtso
force-pushed
the
solana_rbpf/v0.8.0
branch
2 times, most recently
from
4e57907
to
5aee45d
Compare
Codecov Report
@@ Coverage Diff @@
## master #33679 +/- ##
========================================
Coverage 81.8% 81.8%
========================================
Files 806 806
Lines 217893 217065 -828
========================================
- Hits 178285 177774 -511
+ Misses 39608 39291 -317 |
Lichtso
force-pushed
the
solana_rbpf/v0.8.0
branch
from
5aee45d
to
7356fe4
Compare
alessandrod
reviewed
Oct 20, 2023
| @@ -39,44 +40,46 @@ use { | |||
| }, | |||
| }; | |||
|
|
|||
| pub type ProcessInstructionWithContext = BuiltinFunction<InvokeContext<'static>>; | |||
| pub type BuiltinFunctionWithContext = BuiltinFunction<InvokeContext<'static>>; | |||
|
|
|||
| /// Adapter so we can unify the interfaces of built-in programs and syscalls | |||
| #[macro_export] | |||
| macro_rules! declare_process_instruction { | |||
There was a problem hiding this comment.
nit: I think this macro and its callers would look less weird if the macro had a pattern where the
the ident is optional and defaults to Entrypoint
There was a problem hiding this comment.
We should rename a lot of things, but want to do that in different PRs.
"Entrypoint" is bad because in PRv2 every function can be an entrypoint.
| MemoryMapping::new(Vec::new(), &mock_config, &SBPFVersion::V2).unwrap(); | ||
| let mut result = ProgramResult::Ok(0); | ||
| process_instruction( | ||
| let mut vm = EbpfVm::new( |
There was a problem hiding this comment.
As discussed on slack please add a comment explaining why it's ok to hardcode
here, and hardcode v1 for now
Replaces declare_syscall!() with declare_builtin_function!(). Removes Config::encrypt_runtime_environment. Simplifies error propagation.
Lichtso
force-pushed
the
solana_rbpf/v0.8.0
branch
from
7356fe4
to
eaec288
Compare
alessandrod
approved these changes
Oct 20, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
* Bumps solana_rbpf to v0.8.0 * Adjustments: Replaces declare_syscall!() with declare_builtin_function!(). Removes Config::encrypt_runtime_environment. Simplifies error propagation. (cherry picked from commit a5c7c99) # Conflicts: # Cargo.toml # programs/bpf_loader/src/syscalls/mod.rs # programs/sbf/Cargo.toml # runtime/src/bank/tests.rs
Lichtso
added a commit
that referenced
this pull request
Oct 20, 2023
* Bumps solana_rbpf to v0.8.0 * Adjustments: Replaces declare_syscall!() with declare_builtin_function!(). Removes Config::encrypt_runtime_environment. Simplifies error propagation. (cherry picked from commit a5c7c99)
Lichtso
added a commit
that referenced
this pull request
Oct 20, 2023
* Bumps solana_rbpf to v0.8.0 * Adjustments: Replaces declare_syscall!() with declare_builtin_function!(). Removes Config::encrypt_runtime_environment. Simplifies error propagation. (cherry picked from commit a5c7c99)
Lichtso
added a commit
that referenced
this pull request
Oct 21, 2023
* Bumps solana_rbpf to v0.8.0 * Adjustments: Replaces declare_syscall!() with declare_builtin_function!(). Removes Config::encrypt_runtime_environment. Simplifies error propagation. (cherry picked from commit a5c7c99)
Lichtso
added a commit
that referenced
this pull request
Oct 21, 2023
* updated inner_call for hashing fn to follow generic approach (#33128) * updated inner_call for hashing fn to follow generic approach * different hash compute budget values for all digests * fixed conflicts * reverted changes to compute_budget.rs and added 3method to trait to get compute budget values * updated type for result fn for HasherImpl * using Hash directly in result fn, got rid of HASH_BYTES and removed comment form compute_budget * updated import statement * cargo fmt -all * removed unused import and reference related warning * oops forgot semicolon * removed trailing white space (cherry picked from commit a60d185) * Bump solana_rbpf to v0.8.0 (#33679) * Bumps solana_rbpf to v0.8.0 * Adjustments: Replaces declare_syscall!() with declare_builtin_function!(). Removes Config::encrypt_runtime_environment. Simplifies error propagation. (cherry picked from commit a5c7c99) --------- Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solana_rbpf v0.8.0 was released.